Remove interrupt support (no interrupt on chip or breakout) #31
Conversation
|
👋 Thanks for this pull request! Unfortunately, it looks like the automated continuous integration (CI) test(s) failed. These can be tricky to fix so we've written a guide on how to fix them locally. It has pages about running pre-commit locally and another about building the docs locally with sphinx. Thanks for contributing to CircuitPython! If you have more questions, feel free to join the Adafruit Discord and post in #circuitpython-dev. |
Updating https://github.com/adafruit/Adafruit_CircuitPython_MCP230xx to 2.5.15 from 2.5.14: > Merge pull request adafruit/Adafruit_CircuitPython_MCP230xx#60 from regicidalplutophage/patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_VEML7700 to 2.0.2 from 2.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_VEML7700#31 from adafruit/anecdata-patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
|
I don't think you made the right thing by removing the interrupts notion. They are usable even if there is no dedicated pin. The chip has a feature of setting the interrupt bits (in the ALS_INT register) with persistence protection (ALS_PERS) which you can read instead of the ALS register. This is helpful for continuous ambient light tracking with smoothing done by VEML7700 instead of your custom logic that would require more I2C communication. |
Remove mentions and register settings for interrupts. The chip only has power, ground, SDA, and SCL. No interrupt pin on breakout either.
The datasheet notes on p.7:
The docs were confusing for including (unsupported) interrupt features.